💻 Mission 11

B1 · 15 min

Code Review: Give and Receive Feedback

I can answer code review comments politely and give feedback on a teammate's code.
Alex has reviewed your pull request #482 and left a few comments. You agree with one of them, but not with another. After that, Alex asks you to review his pull request.
Review on #482
Alex commented on src/orders/service.ts, line 58
Nit: could we rename d to deliveryDate?
Alex commented on src/orders/service.ts, line 73
What do you think about moving this query to the repository?
Looks good otherwise.
Alex does not give orders. He asks: “could we…?” and “What do you think about…?”

Your mission

Answer Alex's comments: accept one and politely disagree with one. Then give Alex polite feedback on his code.

Keep learning

Code Review: Give and Receive Feedback | Sunny Academy